[Select] Simpler onChange event.target logic #12231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12205. Using
event.target.dataset
doesn't make much sense in this context. The target could be coming from any element that triggered the click event. People can useevent.currentTarget.dataset
instead.The current spread syntax is pointless. The spread operator is using the iteration protocols to navigate over elements and collect the results (with arrays) or to copy enumerable properties (with objects).
But:
Instead, let's make a bold move. Yes, we try to make the event match the native change event at the cost of altering the event.