Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add Complementary Project - create-mui-theme #12269

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

usulpro
Copy link
Contributor

@usulpro usulpro commented Jul 24, 2018

Hi guys! Thank you for this project!

I want to introduce create-mui-theme.
It's the online tool allowing to create color palettes via https://material.io/tools/color and turn them into Material-UI themes.
Demo: https://react-theming.github.io/create-mui-theme/
Source: https://github.com/react-theming/create-mui-theme

Could you kindly consider to add it to your Complementary Projects list?

image

@mbrookes
Copy link
Member

@usulpro Nice job. I really like your geometric color swatch!

Funny to see the color tool URL paste functionality which we temporarily had in the docs color tool PR.

Always happy to see alternatives, and new additions to the Complementary Projects section (plenty more out there that haven't taken the time to create a PR), but in the interest of fairness, and without a better sort criteria, I wonder if this should come at the bottom of the list?

@oliviertassinari
Copy link
Member

@usulpro Oh yes!
@mbrookes What do you think of having a link toward this project in this section? https://material-ui.com/style/color/#material-color-tool. Idealy, I think that it would be awesome to accept a https://material.io/tools/color URL for changing the Material-UI theme live like you did with the color tool 😍.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 24, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 24, 2018

@mbrookes
Copy link
Member

mbrookes commented Jul 24, 2018

@oliviertassinari No issues linking to this in in the color tool section (more is better, thank you @usulpro!).

Equally, no issue reinstating the facility to paste a material.io color URL in the docs, I'm just not convinced of the utility of such a feature now that we have a native color picker. Copy / paste was not fun.

@usulpro
Copy link
Contributor Author

usulpro commented Jul 25, 2018

Thank you, guys, for your kind feedback!

@mbrookes Sure, have moved it to the bottom, I just was in doubt whether should I follow the alphabetical order or break it ☺️

@oliviertassinari Thanks, I started to migrate storybook-addon-material-ui to Material-UI v1.x.x compatibility in the latest ver (it's WIP at this moment).

@mbrookes
Copy link
Member

mbrookes commented Jul 25, 2018

I just was in doubt whether should I follow the alphabetical order

Oh, my bad - I didn't notice it was alphabetical! In that case feel free to drop the last commit.

@usulpro
Copy link
Contributor Author

usulpro commented Jul 25, 2018

Ok, done :)

@mbrookes mbrookes merged commit b536aec into mui:master Jul 25, 2018
@oliviertassinari oliviertassinari changed the title Add Complementary Project - create-mui-theme [docs] Add Complementary Project - create-mui-theme Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants