Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve ListItem and BottomNavigationAction docs #12295

Merged
merged 3 commits into from
Jul 27, 2018
Merged

[docs] Improve ListItem and BottomNavigationAction docs #12295

merged 3 commits into from
Jul 27, 2018

Conversation

vkentta
Copy link

@vkentta vkentta commented Jul 27, 2018

Improve documentation for:

  • ListItem disabled property
  • BottomNavigationAction showLabel property

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 27, 2018
@oliviertassinari
Copy link
Member

@vkentta Thanks, now to get the pull request with a green CI, you need to run yarn docs:api to update the markdowns.

@vkentta
Copy link
Author

vkentta commented Jul 27, 2018

Alright, will do that.

@oliviertassinari oliviertassinari merged commit d5bab6c into mui:master Jul 27, 2018
@oliviertassinari
Copy link
Member

@vkentta Perfect!

@vkentta vkentta deleted the improve_docs branch July 27, 2018 10:17
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
This was referenced Mar 26, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkentta @oliviertassinari