Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpeedDial] - remove unecessary 'onKeyDown' prop sent to SpeedDialAction #12405

Closed
wants to merge 1 commit into from
Closed

[SpeedDial] - remove unecessary 'onKeyDown' prop sent to SpeedDialAction #12405

wants to merge 1 commit into from

Conversation

zanerock
Copy link

@zanerock zanerock commented Aug 3, 2018

I added a 'zero warnings' unit test to catch out the error and then removed the setting of the (seemingly) no-longer-needed prop on the child SpeedDialAction children. I also manually tested on my own app.

closes #12159

@oliviertassinari oliviertassinari added the package: lab Specific to @mui/lab label Aug 4, 2018
@mbrookes
Copy link
Member

mbrookes commented Aug 5, 2018

@zanerock I'm not sure that this is redundant, so much as that Tooltip broke SpeedDialAction keyboard interaction at some point (#12361), so that it doesn't currently do anything. That doesn't mean it isn't needed...

@zanerock
Copy link
Author

zanerock commented Aug 7, 2018

Thanks for the link to #12361, I get it. I expect to have time to take another run at it later this week.

@zanerock zanerock closed this Aug 9, 2018
@zanerock
Copy link
Author

zanerock commented Aug 9, 2018

I took another run at fixing it, but I cannot tell what 'onKeyDown' being added by SpeedDial is doing. It looks like the only other place for it to go is the Button created by SpeedDialAction, but it's not. But if the idea from #12361 is to be able to tab to the action buttons, then the tabIndex={-1} would seem to break that. I tested manually, and I could tab to the FAB just fine, but I couldn't tab to the action buttons as expected.

@mbrookes Is it possible the problem causing #12159 (warnings from Tooltip) was introduced by a partial fix to #12361 (FAB actions not tab accessible)? It would help to know which was added first: creating the onKeyDown property for SpeedDialAction in SpeedDial or the exactProps requirement in Tooltip? I've got to run, but can check blame later...

@oliviertassinari oliviertassinari added component: speed dial This is the name of the generic UI component, not the React module! and removed package: lab Specific to @mui/lab labels Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: speed dial This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants