Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppBar] Add position="relative" #12790

Merged
merged 3 commits into from
Sep 6, 2018
Merged

[AppBar] Add position="relative" #12790

merged 3 commits into from
Sep 6, 2018

Conversation

jgoux
Copy link
Contributor

@jgoux jgoux commented Sep 6, 2018

After the discussion here, I added relative to the allowed values of the prop position for the AppBar component.

@eps1lon
Copy link
Member

eps1lon commented Sep 6, 2018

You need to run yarn docs:api locally and commit the changes.

@oliviertassinari oliviertassinari added component: app bar This is the name of the generic UI component, not the React module! new feature New feature or request labels Sep 6, 2018
@oliviertassinari
Copy link
Member

@eps1lon Having people to run yarn docs:api is a real bottleneck. But it's so convenient when working on the generation script, fixing issues or spotting regressions. I fail to see a better tradeoff. What do you think?

@oliviertassinari oliviertassinari merged commit f9b5810 into mui:master Sep 6, 2018
@oliviertassinari
Copy link
Member

@jgoux Awesome, your very first pull request here 😍😛!

@eps1lon
Copy link
Member

eps1lon commented Sep 7, 2018

@oliviertassinari
What was confusing to me is the name of the step that failed. It was not obvious what the issue was. I think renaming this to "yarn docs:api changes commited?" or something might help here.

Maybe rework the Contributing.md and add a "common CI failures and how to solve"-section is also a good idea. Currently the yarn docs:api step is only described after "Visit GitHub and make your pull request"

@oliviertassinari
Copy link
Member

think renaming this to "yarn docs:api changes commited?" or something might help here

👍

marcelpanse pushed a commit to marcelpanse/material-ui that referenced this pull request Oct 2, 2018
* Add position="relative"

* Update AppBar types

* yarn docs:api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: app bar This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants