Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkbox] Revert input indeterminate support #12803

Merged
merged 2 commits into from
Sep 7, 2018
Merged

[Checkbox] Revert input indeterminate support #12803

merged 2 commits into from
Sep 7, 2018

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 7, 2018

See #12773 for reasons that native indeterminate won't be supported. A short summary is added to the official docs.

Closes #12772

@mbrookes mbrookes added the component: checkbox This is the name of the generic UI component, not the React module! label Sep 7, 2018
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Sep 7, 2018
@oliviertassinari oliviertassinari merged commit 29ede57 into mui:master Sep 7, 2018
@oliviertassinari
Copy link
Member

@eps1lon You did great 👍. II have noticed some area of improvement, I'm pushing that further.

@eps1lon eps1lon deleted the revert-input-indeterminate-support branch September 8, 2018 08:11
marcelpanse pushed a commit to marcelpanse/material-ui that referenced this pull request Oct 2, 2018
@eps1lon @marcelpanse
[Checkbox] Revert input indeterminate support (mui#12803)
0ddae17 
* Revert "[Checkbox] Improve indeterminate status (mui#12671)"

This reverts commit b30c9bb.

* [Checkbox] Add comment about missing native indeterminate support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: checkbox This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @oliviertassinari @mbrookes