Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[styles] Use the same class name generator #12818

Merged
merged 1 commit into from
Sep 9, 2018

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 9, 2018

Keep fixing the consequences of #12814.

  • Fix the ssr example to use the same generator
  • Make the counter implementation more tolerant, as we had in 3.0.2 and lower.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation core labels Sep 9, 2018
@@ -1,6 +1,13 @@
/* eslint-disable no-underscore-dangle */

import warning from 'warning';
// The counter-based approach doesn't tolerate any mistake.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be better in 3.0.4

@oliviertassinari oliviertassinari merged commit e07a953 into mui:master Sep 9, 2018
@oliviertassinari oliviertassinari deleted the ssr-fixes branch September 9, 2018 14:46
marcelpanse pushed a commit to marcelpanse/material-ui that referenced this pull request Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant