[SpeedDialAction] Fix className prop being ignored #13161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
the
component: speed dial
mbrookes
approved these changes
Oct 8, 2018
| @@ -107,7 +107,7 @@ class SpeedDialAction extends React.Component { | |||
| <Button | |||
| variant="fab" | |||
| mini | |||
| className={classNames(classes.button, !open && classes.buttonClosed)} | |||
| className={classNames(classNameProp, classes.button, !open && classes.buttonClosed)} | |||
There was a problem hiding this comment.
There is no className variable in the scope. I think that we can use it, no need to rename it classNameProp.
eps1lon
force-pushed
the
feat/lab/SpeedDial/className
branch
from
13c32b8
to
91d8909
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12159 (which was actually closed in #12725)
Merge
classNameof SpeedDialAction into its button component.