v0.11 - [Table] If selected key for some rows gets changed ensure table internal selection array gets updated
#1325
Conversation
| }; | ||
| }, | ||
|
|
||
| componentWillReceiveProps(nextProps) { | ||
| if (this.props.allRowsSelected && !nextProps.allRowsSelected) { | ||
| if (nextProps.rowData !== this.props.rowData) { |
There was a problem hiding this comment.
This could get tricky. The new table implementation does not use rowData; it relies on children. We'll need to check the children for changes instead of rowData which could get quite expensive if we are doing this check every time the component receives props.
There was a problem hiding this comment.
Apologies, I went through that a bit quickly. Will fix.
There was a problem hiding this comment.
No worries; other changes look good. We might want to check the table for performance metrics; recreating a lot of components can get quite expensive.
There was a problem hiding this comment.
I've now fixed this issue. From my testing I can say I don't think performance will be an issue except for very large tables.
v0.11 - [Table] If `selected` key for some rows gets changed ensure table internal selection array gets updated
|
Thanks @hiddentao @jkruder |
zannager
added
the
component: table
Same as #1282 but for v0.11 branch.