Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CircularProgress] Introduce disableShrink property #13430

Merged
merged 5 commits into from
Oct 30, 2018
Merged

[CircularProgress] Introduce disableShrink property #13430

merged 5 commits into from
Oct 30, 2018

Conversation

joshwooding
Copy link
Member

@joshwooding joshwooding commented Oct 28, 2018 •
edited
Loading

Fixes #10327

  • Added disableShrinkAnimation property to CircularProgress
  • Added disableShrinkAnimation tests to CircularProgress
  • Added example to docs

test

eps1lon
eps1lon reviewed Oct 28, 2018
View reviewed changes
packages/material-ui/src/CircularProgress/CircularProgress.js Outdated
/**
* If `true`, the shrink animation is applied. This only works if variant is `indeterminate`
*/
shrinkAnimation: chainPropTypes(PropTypes.bool, props => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be named disableShrinkAnimation according to https://material-ui.com/guides/api/#property-naming

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! This makes a lot more sense, changed shrinkAnimation to disableShrinkAnimation

@joshwooding
[CircularProgress] changed shrinkAnimation to disableShrinkAnimation
dadbf34 
[docs] changed shrinkAnimation to disableShrinkAnimation
@joshwooding joshwooding changed the title [CircularProgress] Introduce shrinkAnimation property [CircularProgress] Introduce disableShrinkAnimation property Oct 29, 2018
@oliviertassinari oliviertassinari self-assigned this Oct 29, 2018
@oliviertassinari oliviertassinari force-pushed the circular-progress-shrink-animation-prop branch 2 times, most recently from 3491e4e to 17fac1b Compare October 29, 2018 21:49
@oliviertassinari oliviertassinari changed the title [CircularProgress] Introduce disableShrinkAnimation property [CircularProgress] Introduce disableShrink property Oct 29, 2018
@oliviertassinari oliviertassinari added new feature New feature or request component: CircularProgress The React component labels Oct 29, 2018
@oliviertassinari
Copy link
Member

I have renamed the disableShrinkAnimation to disableShrink. Let me know what you think. Also, I have always wanted to guide people around customizing the circular progress. Here is how they can build the same spinner Facebook is using:

oct -29-2018 22-48-14

@oliviertassinari oliviertassinari force-pushed the circular-progress-shrink-animation-prop branch 3 times, most recently from 1b67edd to 4d0e926 Compare October 29, 2018 21:59
@oliviertassinari oliviertassinari removed their assignment Oct 29, 2018
@oliviertassinari oliviertassinari merged commit 6cca823 into mui:master Oct 30, 2018
@oliviertassinari
Copy link
Member

@joshwooding Well done :)

@joshwooding
Copy link
Member Author

@oliviertassinari Thanks for adding the customisation examples. I’m sure they will help a lot of people

@joshwooding joshwooding deleted the circular-progress-shrink-animation-prop branch October 30, 2018 20:05
@oliviertassinari oliviertassinari added the component: progress This is the name of the generic UI component, not the React module! label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: CircularProgress The React component component: progress This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[progress] CircularProgress, length of the line does not animate under load
3 participants
@joshwooding @oliviertassinari @eps1lon