[docs] Use stable context API #13477
Conversation
| sourceCodeRootUrl: PropTypes.string.isRequired, | ||
| }; | ||
|
|
||
| export default EditPage; |
There was a problem hiding this comment.
"Fun" fact: If you don't export anything eslint will not warn you, the runtime will not throw because read of undefined. React will just throw with "expected component but got object".
|
Well done. I like you have extracted blocks of logic into render props, waiting for hooks to be available. |
oliviertassinari
force-pushed
the
docs/stable-context-api
branch
from
1ab3859
to
3399f33
Compare
| @@ -0,0 +1,5 @@ | |||
| import React from 'react'; | |||
|
|
|||
| const PageContext = React.createContext(); | |||
There was a problem hiding this comment.
That's missing the previous default values. They should be present for documentation purposes.
There was a problem hiding this comment.
Maybe a comment in this case?
There was a problem hiding this comment.
Documentation gets outdated. With actual values vscode is able to acquire type information and enables autocomplete.
There was a problem hiding this comment.
Documentation gets outdated.
Do does default values that are never used.
With actual values vscode is able to acquire type information and enables autocomplete.
Ok, that's the why. I'm adding them back.
There was a problem hiding this comment.
I believe that this is actual the typescript language server so any editor (plugin) that is leveraging that benefits. I just like my autocomplete ;)
oliviertassinari
force-pushed
the
docs/stable-context-api
branch
from
e0996e5
to
b94be64
Compare
First step. Removes some noise when tracking down #13394