React 0.14 beta3 support

[juhaelee]

If we could create another branch for react 0.14 I think that would be a better option.

Side note: I'm currently supporting a npm module called material-ui-io if people want to use React 0.14 with material-ui until this main library gains support

[cliffrowley]

+1 and @juhaelee I am about to start using your fork so I'll let you know how things go ;-)

[t-kelly]

+1 I'll also start testing this. Need it for development until the official is released. Thanks!

[andreimc]

What are the benefits of using onTouchTap?

[oliviertassinari]

What are the benefits of using onTouchTap?

Mainly for this reason http://updates.html5rocks.com/2013/12/300ms-tap-delay-gone-away
So by removing the onTouchTap, I believe we gonna have a 300ms delay on safari iOS phones.

[Webkadabra]

Very happy to find that fork! However, it's be great to have 0.14 support for original material-ui ^^

[shaurya947]

We hear y'all! We're probably going to release v0.12 today and will see how we can support react v0.14.0-rc1. :)

[shaurya947]

From what I hear, here's what we need to do to support rc1 of React v0.14:

• change our dependencies (package.jsons)
• limit to two packages: react and react-dom, and separate packages for anything else we're using
• change how we use the refs
• change how findDomNode() is called.

Is there anything else you guys are aware of that I'm missing?

Also, we would still like to support v0.13. So I was thinking we could change our dependencies to something like this

What do you guys think? @oliviertassinari @juhaelee

[oliviertassinari]

change our dependencies

Yes, I think that we can use somethings like >= 0.13.0 < 0.15.0 || ^0.14.0-rc.

we would still like to support v0.13

I agree.

change how we use the refs

What's wrong?

change how findDomNode() is called.

I thinkg that we can use a wrapper like this one

const findDOMNode = ref => React.version < '0.14.0' ? React.findDOMNode(ref) : ref;

or simply React.findDOMNode and keep the warning.

[shaurya947]

I like those ideas @oliviertassinari. We just published v0.12 with the new theming changes, and created a new branch to start looking at v0.14-rc1 support.

If we're using refs for any built-in DOM components, we would need to change them https://facebook.github.io/react/blog/2015/09/10/react-v0.14-rc1.html#dom-node-refs

[shaurya947]

@juhaelee could you update these for rc1 and submit a PR to the react-0.14-support branch instead?

[shaurya947]

I'm not sure if this is still needed after #1751 @juhaelee @oliviertassinari

[oliviertassinari]

docs/src/app/app-routes.jsx changes are interesting!

[shaurya947]

Indeed, just looked at them

[juhaelee]

Sounds like @oliviertassinari's branch is a more updated PR. I haven't gotten around to updating this for react0.14rc or rr1.0, so I'm going to close this PR for now if it's ok with you guys @shaurya947

[shaurya947]

Good with me @juhaelee! Just hoping to get something going soon so we can start supporting rc1 :)