Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Update scrollable property description #14059

Merged
merged 5 commits into from
Jan 3, 2019
Merged

[Tabs] Update scrollable property description #14059

merged 5 commits into from
Jan 3, 2019

Conversation

jmcpeak
Copy link
Contributor

@jmcpeak jmcpeak commented Jan 2, 2019 •
edited
Loading

  1. Update documentation for Tabs/fullWidth property - whitespace/crlf caused the doc to not display correctly.
  2. Small changes - move commas
  3. Add max-len to eslint-disable

1. Update documentation for Tabs/fullWidth property - whitespace caus…
34faa91 
…ed the doc to not display correctly.

2. Small changes - remove unnecessary commas
3. Remove unused constants
4. Add max-len to eslint disable
@jmcpeak
Copy link
Contributor Author

jmcpeak commented Jan 2, 2019

commas after formatted code true look like they are hanging out in mid air

@jmcpeak jmcpeak mentioned this pull request Jan 2, 2019
Closed
2 tasks
@oliviertassinari
Copy link
Member

I believe @joshwooding already took care of the issue. Can you try what we have on the master branch: https://material-ui.netlify.com/api/tabs/?

oliviertassinari
oliviertassinari reviewed Jan 2, 2019
View reviewed changes
packages/material-ui/src/Tabs/Tabs.js Outdated
@@ -453,13 +453,11 @@ Tabs.propTypes = {
*/
onChange: PropTypes.func,
/**
* True invokes scrolling properties and allow for horizontally scrolling
* (or swiping) the tab bar.
* If `true,` it invokes scrolling properties and allow for horizontally scrolling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmcpeak
Copy link
Contributor Author

jmcpeak commented Jan 2, 2019 •
edited
Loading

I believe @joshwooding already took care of the issue. Can you try what we have on the master branch: https://material-ui.netlify.com/api/tabs/?

Yes - fixed there - looks good - and even better - he fixed the core root of the problem.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: tabs This is the name of the generic UI component, not the React module! labels Jan 2, 2019
@oliviertassinari oliviertassinari changed the title [Tabs] documentation - fullWidth property - whitespace caused layout issue [Tabs] Update scrollable property description Jan 2, 2019
@jmcpeak jmcpeak closed this Jan 3, 2019
@oliviertassinari oliviertassinari merged commit 3aa05a8 into mui:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcpeak @oliviertassinari