Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Change dangerouslyUseGlobalCSS to only affect static style sheets #14089

Merged
merged 2 commits into from
Jan 5, 2019
Merged

[styles] Change dangerouslyUseGlobalCSS to only affect static style sheets #14089

merged 2 commits into from
Jan 5, 2019

Conversation

joshwooding
Copy link
Member

@joshwooding joshwooding commented Jan 4, 2019 •
edited by oliviertassinari
Loading

Closes #14087

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. labels Jan 5, 2019
oliviertassinari
oliviertassinari approved these changes Jan 5, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a unit test

@joshwooding
Copy link
Member Author

Thanks for adding the unit test, it slipped my mind 😅

@oliviertassinari oliviertassinari merged commit a62a40f into mui:master Jan 5, 2019
@joshwooding joshwooding deleted the fix-dangerouslyUseGlobalCSS-with-static-styles branch January 5, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshwooding @oliviertassinari