[MenuList] Wrap focus by default, add disableListWrap #14100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 5, 2019 17:45
oliviertassinari
added
the
component: menu
oliviertassinari
force-pushed
the
menu-wrap
branch
from
fea8cf2
to
8e65dd1
Compare
oliviertassinari
changed the title
oliviertassinari
approved these changes
Jan 6, 2019
oliviertassinari
force-pushed
the
menu-wrap
branch
from
8e65dd1
to
4a96f66
Compare
|
@dallin-christensen It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
|
@oliviertassinari Thank you! It was a fun feature to build 👍 |
|
seeing a React warning related to this new
warning textindex.js:1452 Warning: React does not recognize the `disableListWrap` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `disablelistwrap` instead. If you accidentally passed it from a parent component, remove it from the DOM element. in ul (created by List) in List (created by WithStyles(List)) in WithStyles(List) (created by MenuList) in MenuList (created by Menu) in div (created by Paper) in Paper (created by WithStyles(Paper)) in WithStyles(Paper) (created by Popover) in Transition (created by Grow) in Grow (created by WithTheme(Grow)) in WithTheme(Grow) (created by Popover) in RootRef (created by Modal) in div (created by Modal) in Portal (created by Modal) in Modal (created by WithStyles(Modal)) in WithStyles(Modal) (created by Popover) in Popover (created by WithStyles(Popover)) in WithStyles(Popover) (created by Menu) in Menu (created by WithStyles(Menu)) in WithStyles(Menu) (created by SelectInput) in div (created by SelectInput) in SelectInput (created by InputBase) in div (created by InputBase) in InputBase (created by Context.Consumer) in WithFormControlContext(InputBase) (created by WithStyles(WithFormControlContext(InputBase))) in WithStyles(WithFormControlContext(InputBase)) (created by Input) in Input (created by WithStyles(Input)) in WithStyles(Input) in Select (created by Context.Consumer) in WithFormControlContext(Select) (created by WithStyles(WithFormControlContext(Select))) |
|
here's a small PR to fix the React warning #14226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves a feature mentioned in issue #13865
The MenuList component now wraps by default, gave disableListWrap prop for users to opt-out, updated docs accordingly.