[core] Enable innerRef on ListItem and MenuItem #14423
Conversation
eps1lon
added
new feature
Required in MenuList and missed in mui#13722
eps1lon
force-pushed
the
feat/MenuList/enable-proper-refs
branch
from
4b9c69c
to
2814821
Compare
| @@ -28,7 +28,7 @@ module.exports = [ | |||
| name: 'The size of the @material-ui/core modules', | |||
| webpack: true, | |||
| path: 'packages/material-ui/build/index.js', | |||
| limit: '91.2 KB', | |||
| limit: '91.3 KB', | |||
There was a problem hiding this comment.
Once we fully commit to forwardRef push it is probably a good idea to reexamine how much it actually cost. I feel like most of this is due to the local displayName "logic" and we can probably move this to the getDisplayName logic in withStyles.
There was a problem hiding this comment.
@eps1lon I think that we should take advantage of the v4 breaking change card it's offering us to aggressively try changes, then adjust based on the people & real life implications.
There was a problem hiding this comment.
My exact same thoughts. I would've waited a bit longer usually (especially concerning the RFC) but I think it's ok to implement RFCs prematurely so that people can play around with it and actually see the impact of those changes.
Required in
MenuListand missed in #13722.Prerequisite for #13676 and partially addresses #14415. Filing this as a separate PR so that it won't be lost in changelog.