Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SpeedDialAction] Pass onTouchEnd event onto called onClick handler #14641

Merged
merged 3 commits into from
Mar 7, 2019
Merged

[SpeedDialAction] Pass onTouchEnd event onto called onClick handler #14641

merged 3 commits into from
Mar 7, 2019

Conversation

hburrows
Copy link
Contributor

The SpeedDialAction component treats the onClick property specially to support touch interfaces.
However, when usingonTouchStart/onTouchEnd it doesn't pass the Event object onto onClick which prevents things like calling preventDefault(). This PR forwards the Event object passed to onTouchEnd onto onClick

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 23, 2019 •
edited
Loading

Details of bundle changes.

Comparing: cbed923...ad9cdf2

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core/Paper 0.00% 0.00% 83,040 83,040 21,410 21,410
@material-ui/core/Paper.esm 0.00% 0.00% 76,728 76,728 20,462 20,462
@material-ui/core 0.00% 0.00% 484,877 484,877 130,093 130,093
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,235 16,235 5,159 5,159
@material-ui/lab 0.00% 0.00% 295,473 295,475 86,174 86,176
@material-ui/styles 0.00% 0.00% 63,755 63,755 18,119 18,119
@material-ui/system 0.00% 0.00% 15,915 15,915 3,938 3,938
colorManipulator 0.00% 0.00% 2,290 2,290 838 838
Button 0.00% 0.00% 212,888 212,888 61,970 61,970
Modal 0.00% 0.00% 211,094 211,094 61,687 61,687
@material-ui/core/Popper 0.00% 0.00% 146,815 146,815 46,826 46,826
@material-ui/core/useMediaQuery 0.00% 0.00% 9,217 9,217 3,503 3,503
docs.main 0.00% 0.00% 676,139 676,139 205,127 205,127
docs.landing 0.00% 0.00% 48,963 48,963 10,275 10,275
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 320,511 320,511 84,731 84,731

Generated by 🚫 dangerJS against ad9cdf2

@hburrows hburrows changed the title SpeedDialAction - pass onTouchEnd event onto called onClick handler [SpeedDialAction] Pass onTouchEnd event onto called onClick handler Feb 23, 2019
@oliviertassinari oliviertassinari added the component: speed dial This is the name of the generic UI component, not the React module! label Feb 24, 2019
hburrows added a commit to hburrows/material-ui that referenced this pull request Mar 5, 2019
@hburrows
Reverting mistakenly including PR mui#14641
1529dfb
oliviertassinari pushed a commit that referenced this pull request Mar 7, 2019
@hburrows @oliviertassinari
[SpeedDial] Change actions background color (#14640)
622066c 
* Add color property for passing to Fab component

* Fix eslint line length issue

* Updating documentation markdown; updating typescript declaration

* Changing default color of action buttons from grey to white to align closer with spec

* Reverting dedicated color prop in favor of using ButtonProps for expressing Fab color

* Updating doc after reverting dedicated color prop

* Reverting mistakenly including PR #14641

* Adding back default Fab color styling of 'primary'

* Changing how Fab color is faulted; previous impl. doesn't work correclty

* Remove redundant code
@oliviertassinari oliviertassinari merged commit ddc50cc into mui:next Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: speed dial This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hburrows @mui-pr-bot @mbrookes @oliviertassinari