Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ToggleButton] Convert to function component #14965

Merged
merged 4 commits into from
Mar 24, 2019
Merged

[ToggleButton] Convert to function component #14965

merged 4 commits into from
Mar 24, 2019

Conversation

joshwooding
Copy link
Member

@joshwooding joshwooding commented Mar 19, 2019 •
edited
Loading

Converted ToggleButton to a function component.

@joshwooding joshwooding added the component: toggle button This is the name of the generic UI component, not the React module! label Mar 19, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 19, 2019 •
edited
Loading

@material-ui/lab: parsed: -0.24% 😍, gzip: -0.09% 😍

Details of bundle changes.

Comparing: 1d91e0a...c4d8e2c

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 352,667 352,667 90,540 90,540
@material-ui/core/Paper 0.00% +0.01% 🔺 67,382 67,382 19,709 19,710
@material-ui/core/Paper.esm 0.00% 0.00% 61,143 61,143 18,799 18,799
@material-ui/core/Popper 0.00% +0.02% 🔺 30,460 30,460 10,527 10,529
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 17,384 17,384 5,727 5,727
@material-ui/core/useMediaQuery 0.00% 0.00% 2,469 2,469 1,038 1,038
@material-ui/lab -0.24% -0.09% 152,123 151,758 44,511 44,469
@material-ui/styles 0.00% -0.01% 52,565 52,565 15,330 15,328
@material-ui/system 0.00% -0.02% 17,138 17,138 4,519 4,518
Button -0.00% +0.14% 🔺 90,889 90,888 26,921 26,959
Modal 0.00% +0.04% 🔺 84,633 84,633 25,232 25,242
colorManipulator 0.00% 0.00% 3,232 3,232 1,300 1,300
docs.landing 0.00% 0.00% 51,843 51,843 11,349 11,349
docs.main -0.06% -0.02% 647,616 647,196 200,961 200,911
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 301,815 301,815 83,756 83,756

Generated by 🚫 dangerJS against c4d8e2c

@oliviertassinari oliviertassinari added core new feature New feature or request and removed core labels Mar 21, 2019
@joshwooding joshwooding force-pushed the toggle-button-function-component branch from e31e5f9 to b1af863 Compare March 23, 2019 13:28
@joshwooding joshwooding marked this pull request as ready for review March 23, 2019 14:17
@joshwooding joshwooding force-pushed the toggle-button-function-component branch from 8de76e8 to c4d8e2c Compare March 23, 2019 16:10
@oliviertassinari oliviertassinari mentioned this pull request Mar 23, 2019
Merged
oliviertassinari
oliviertassinari reviewed Mar 23, 2019
View reviewed changes
packages/material-ui-lab/src/ToggleButton/ToggleButton.test.js
@@ -21,6 +22,10 @@ describe('<ToggleButton />', () => {
classes = getClasses(<ToggleButton value="classes">Hello World</ToggleButton>);
});

it('does forward refs', () => {
testRef(<ToggleButton value="classes">Hello World</ToggleButton>, mount);
Copy link
Member

@oliviertassinari oliviertassinari Mar 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With @eps1lon's work on #14958, we should be able to kill this test class going forward.

@oliviertassinari oliviertassinari merged commit ae31efe into mui:next Mar 24, 2019
@joshwooding joshwooding deleted the toggle-button-function-component branch March 24, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: toggle button This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshwooding @mui-pr-bot @oliviertassinari