-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dialog] Prepare deprecation of withMobileDialog #14992
Merged
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:remove-withMobileDialog
Jun 22, 2019
Merged
[Dialog] Prepare deprecation of withMobileDialog #14992
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:remove-withMobileDialog
Jun 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
breaking change
component: dialog
This is the name of the generic UI component, not the React module!
deprecation
New deprecation message
and removed
breaking change
labels
Mar 21, 2019
oliviertassinari
changed the title
[Dialog] Remove withMobileDialog
[Dialog] Deprecate withMobileDialog
Mar 21, 2019
Details of bundle changes.Comparing: d1a7d76...e6e251b
|
oliviertassinari
force-pushed
the
remove-withMobileDialog
branch
3 times, most recently
from
March 21, 2019 13:32
382f483
to
e6e251b
Compare
56 tasks
oliviertassinari
added
on hold
There is a blocker, we need to wait
and removed
PR: good for merge
labels
Mar 22, 2019
oliviertassinari
changed the title
[Dialog] Deprecate withMobileDialog
[Dialog] Prepare deprecation of withMobileDialog
Jun 21, 2019
oliviertassinari
force-pushed
the
remove-withMobileDialog
branch
from
June 21, 2019 08:26
e6e251b
to
b683999
Compare
oliviertassinari
added
docs
Improvements or additions to the documentation
and removed
deprecation
New deprecation message
on hold
There is a blocker, we need to wait
labels
Jun 21, 2019
No bundle size changes comparing 6957c91...b683999 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: dialog
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the deprecation of the
withMobileDialog()
higher order component. The hook API allows a simpler and more flexible solution:The deprecation will happen in the next few months, to prepare v5. For now, I have only removed it from the demo. For people that can't use hooks, withWidth is still a viable alternative, we might provide a withMediaQuery hook in the future.