[TextField] Added hintStyle property #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bgribben - Can you also add a prop description here as well please? |
bgribben
force-pushed
the
text-field-hint-style-property
branch
from
2fa6942
to
a19f53d
Compare
|
Added the prop description @hai-cea - should be good to go now. |
shaurya947
added a commit
that referenced
this pull request
Sep 29, 2015
[TextField] Added hintStyle property
| @@ -259,7 +261,7 @@ let TextField = React.createClass({ | |||
| ) : null; | |||
|
|
|||
| let hintTextElement = hintText ? ( | |||
| <div style={this.mergeAndPrefix(styles.hint)}>{hintText}</div> | |||
| <div style={this.mergeAndPrefix(styles.hint, this.props.hintStyle)}>{hintText}</div> | |||
There was a problem hiding this comment.
hintStyle instead of this.props.hintStyle
There was a problem hiding this comment.
Perhaps trivial but good catch @oliviertassinari
@bgribben quick fix please? :)
zannager
added
the
component: text field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a 'hintStyle' property to text-field for styling hint text.
Also included documentation.