[EnhancedTextarea] add rowsMax property #1562
Conversation
| desc: 'Number of rows to display when multiLine option is set to true.' | ||
| }, | ||
| { | ||
| name: 'rowMax', |
| @@ -2,6 +2,28 @@ const React = require('react'); | |||
| const StylePropable = require('./mixins/style-propable'); | |||
| const AutoPrefix = require('./styles/auto-prefix'); | |||
|
|
|||
| const rowsHeight = 24; | |||
|
|
|||
| const styles = { | |||
There was a problem hiding this comment.
I see that you made the styles global.
Do you think in the future we could use some styles from the theme for this component? That would cause issues with this global approach right? Nearly all components implement a getStyles() method. I think we should be consistent about that. What do you think @oliviertassinari?
There was a problem hiding this comment.
I'm using a global styles for performance reasons.
There was a problem hiding this comment.
What do you think @hai-cea?
There was a problem hiding this comment.
@shaurya947 @oliviertassinari I think declaring the constant in this way is fine here. Since the styles object doesn't depend on the instance of the component, declaring the constant outside is a little more efficient.
[EnhancedTextarea] add rowsMax property
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.16.0 to 7.19.0. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.16.0...v7.19.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zannager
added
component: text field
No description provided.