[AppBar] make IconMenu to render correctly #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliviertassinari
commented
Sep 3, 2015
oliviertassinari
commented
| @@ -101,6 +103,7 @@ let IconMenu = React.createClass({ | |||
|
|
|||
| let iconButton = React.cloneElement(iconButtonElement, { | |||
| onKeyboardFocus: this.props.onKeyboardFocus, | |||
| iconStyle: iconStyle, | |||
There was a problem hiding this comment.
I'm wondering if I should use iconButtonElement.iconStyle
|
What exactly is the issue here @oliviertassinari ? |
|
This improve composability. This fix the style. |
|
Oh I see, it does fix the style somewhat. Thanks for the fix @oliviertassinari |
shaurya947
added a commit
that referenced
this pull request
Sep 30, 2015
[AppBar] make IconMenu to render correctly
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
Co-authored-by: Dmitriy Kovalenko <dmtr.kovalenko@outlook.com>
zannager
added
the
component: app bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.