-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[styles] Use react-jss hook API internally #16180
Conversation
Details of bundle changes.Comparing: 4909bd8...66e8963
|
2b3f2e6
to
1ea1d6b
Compare
1ea1d6b
to
66e8963
Compare
I will resume it later. |
@oliviertassinari what happens ? This not work correctly several empty tags classes don’t match and more not it’s only performance , don’t work box and others Any plans for fix this or not ? |
The long term priority is to leverage styled components. We will start to hide |
I understand the problem it’s the system don’t work if you want to use Box this don’t match ssr with the client never. Btw thanks for the response . |
They shouldn't be any SSR mismatch. It's very likely a miss configuration in the projet your are working with. |
I use the default test and the server render has a different result, this it’s becouse the useStyles it’s called two times on the first render so the first time match but after don’t match becouse it’s execute two time on the first render so react don’t rehydrate the class |
As we want to move toward a style adapter architecture (JSS, styled-components, etc) #16238, the more we can depend on the existing style solutions, the better. @kof and his team have done a great job with their new react-jss hook API. it's x2 faster for dynamic props than what we have, and only ~25% slower than styled-components. It should solve most of the problems in