fix eslint errors #1619
Closed
fix eslint errors #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would rather keep |
|
I feel we should just drop the specification of this rule from the .eslintrc file. |
|
Hey guys - I'm with @shaurya947 . I think we should just drop this rule because http://stackoverflow.com/questions/6961526/correct-value-for-disabled-attribute |
|
So let's just set |
|
fine by me :) |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* Make value for picker be a generic type * Spread new props from passing to the dom element * Split makePickerWith state hoc * Better type inference for new makePickerWithWrapper * Refactor and opimize shared prop types inference for pickers * Rename eome type names and files * Integrate validation back to usePickerState * Remove DateRangePicker code * Remove DateRangePickerUsage from index module * Fix small linter and ts errors * Fix build erros * Run prettier manually * Display calendars for date range * [WiP] Work on displaying 2 calendars one by one * WATER ON MY MAC * Proper display days with margins with range highlights * Fix unexpected month switchings * Implement range preview * Optimize rerenders of Day and DateRangeDay, closes mui#1306 * Fix crash and missing rerender * Optimize rerendering performace of <Day /> * Use popper for date range wrapper * Proper displaying values in DateRangePIckerInput * Implement ClickAwayListner for popper wrapper * Fix slide animation in date range picker * Reorganize test folders * Reorganize integration test folder * Add focus managment logic * Implement autoscrolling for switching between range start/end * Improve date range picker with disabling min/max dates * Update date-io adapter version to 2.5.0 * Do not display range preview on highlighted days * Better focus and blur handling for popper * Fix range preview border style * Fix type erros * Fix fantom borders appearing * Better styling for popper and possibility to replace transition * Fix missing mui globals * Fix werid memoization issue in Safari * Implement mobile version of DateRangePicker * Better displaying in mobile mode * Make possible to switch view by clicking on month and year header * Properly spread props to mobile keyboard input view * Fix ts erros and enable api generation * Fix example ts-checks * Fix ts error in ServerRerquest.example.jsx * Fix error if mouning in open state * Add props test for DateRangePickers * Export responsive date range picker by default * Add missing displayName to the ToolbarButton * Small enhancmenets * Fix inclusivity of range for non-datefns livs * Fix ts error * Remove fake data from range example * Use tsx in date range picker examples * Add `startText` and `endText` props * Update material-ui and fix createSvgIcon import, closes mui#1619 * Use new TextField `focused` prop for highlighting * Close picker after range selected * Update jss version * Add more date-range-manager tests * More examples and possibility to change wrapper mode for static wrapper * Fix ts wrapper props inferring * Update lib/src/views/Calendar/CalendarView.tsx Co-Authored-By: Olivier Tassinari <olivier.tassinari@gmail.com> * Update docs/pages/demo/daterangepicker/CalendarsDateRangePicker.example.tsx Co-Authored-By: Olivier Tassinari <olivier.tassinari@gmail.com> * Update createSvgIcon imports * Fix ts inferrence for static wrapper props * Add missing props spreading * Fix more build errors * Update lib/src/__tests__/setup.js Co-Authored-By: Olivier Tassinari <olivier.tassinari@gmail.com> * Address review * forwardRef for DateRangePicker Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
zannager
added
package: system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed the build was failing - this seems to sort it, though I can't say I'm certain it is to my taste.