Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[useMediaQuery] Defensive logic against matchMedia not available #16196

Merged

Conversation

oliviertassinari
Copy link
Member

Closes #16184

@mui-pr-bot
Copy link

mui-pr-bot commented Jun 12, 2019

Details of bundle changes.

Comparing: cddc4cf...1323b2a

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.02% 🔺 -0.00% 318,722 318,790 87,596 87,595
@material-ui/core/Paper 0.00% 0.00% 68,349 68,349 20,370 20,370
@material-ui/core/Paper.esm 0.00% 0.00% 61,642 61,642 19,172 19,172
@material-ui/core/Popper 0.00% 0.00% 28,966 28,966 10,414 10,414
@material-ui/core/Textarea 0.00% 0.00% 5,513 5,513 2,370 2,370
@material-ui/core/TrapFocus 0.00% 0.00% 3,755 3,755 1,581 1,581
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,016 16,016 5,821 5,821
@material-ui/core/useMediaQuery +2.69% 🔺 +1.38% 🔺 2,529 2,597 1,088 1,103
@material-ui/lab 0.00% 0.00% 139,044 139,044 42,787 42,787
@material-ui/styles 0.00% 0.00% 51,769 51,769 15,344 15,344
@material-ui/system 0.00% 0.00% 14,926 14,926 4,269 4,269
Button 0.00% 0.00% 84,337 84,337 25,711 25,711
Modal 0.00% 0.00% 20,343 20,343 6,682 6,682
colorManipulator 0.00% 0.00% 3,904 3,904 1,544 1,544
docs.landing 0.00% 0.00% 55,232 55,232 13,947 13,947
docs.main +0.01% 🔺 0.00% 650,888 650,944 204,998 205,007
packages/material-ui/build/umd/material-ui.production.min.js +0.02% 🔺 +0.02% 🔺 292,119 292,187 83,462 83,476

Generated by 🚫 dangerJS against 1323b2a

@oliviertassinari oliviertassinari merged commit 73d7814 into mui:master Jun 13, 2019
@oliviertassinari oliviertassinari deleted the use-media-query-feature-detect branch June 13, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: withWidth fails on the server side because of useMediaQuery
3 participants