[bugfix] moves key prop to TableHeaderColumn #1625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Key property was defined on the Checkbox element, causing React to throw a warning when enumerating any TableHeaderColumns - Fixes mui#1583
|
Is there anything I can do to help get this merged? It's certainly not critical but multiple people have expressed interest in getting this fixed as seen in #1583 |
| @@ -127,11 +127,10 @@ let TableHeader = React.createClass({ | |||
| }, | |||
|
|
|||
| _getSelectAllCheckboxColumn(props) { | |||
| if (!this.props.displaySelectAll) return this._getCheckboxPlaceholder(props); | |||
| if (!this.props.displaySelectAll) return this._getCheckboxPlaceholder(props); | |||
There was a problem hiding this comment.
can you remove the trailling space?
oliviertassinari
added
the
PR: needs revision
|
@AllenSH12 I'm closing this PR. The issue was fixed by #2030. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to throw a warning when enumerating any TableHeaderColumns