[test] Add Select a11y fixture #16308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing ac39205...bcd730d |
|
Closing for now. a11y of Select doen't follow WAI-ARIA anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a very basic setup to verify keyboard navigation for the Select component. The introduced test is failing right now but (partially) fixed with #16294. Opened this separately in case we need to discuss the test. Wanted to make sure we separate the test and implementation.
Interesting part is 933986b. The rest is just DX.
Thought about moving instructions into a separate README but then you need two separate windows so I'd rather have these next to each other.
/cc @ianschmitz @ryancogswell