Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useMediaQuery server-side example #16312

Closed
wants to merge 1 commit into from
Closed

Fix useMediaQuery server-side example #16312

wants to merge 1 commit into from

Conversation

fzaninotto
Copy link
Contributor

Note that this import is really hard to guess, I'd prefer that useMediaQueryTheme is exported in the main index.

@eps1lon eps1lon added bug 🐛 Something doesn't work package: material-ui Specific to @mui/material labels Jun 20, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing ac39205...4b9be47

Generated by 🚫 dangerJS against 4b9be47

eps1lon
eps1lon requested changes Jun 20, 2019
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug is that we don't export it from core/useMediaQuery. Imports from below 2nd level are discouraged.

@fzaninotto
Copy link
Contributor Author

OK, closing as exporting in useMediaQuery should be done in several files, and I was using Github to modify this.

@fzaninotto fzaninotto closed this Jun 20, 2019
@oliviertassinari oliviertassinari mentioned this pull request Jul 5, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon requested changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fzaninotto @mui-pr-bot @eps1lon