Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Re-export missing typings #16490

Merged
merged 1 commit into from
Jul 7, 2019
Merged

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jul 5, 2019

Added missing exports to @material-ui/core typings

  • MuiThemeProvider
  • responsiveFontSizes
  • styled

It doesn't export all types from styles, but at least it exports the same as the JS file.

Closes #16489

@merceyz
Copy link
Member Author

merceyz commented Jul 5, 2019

@eps1lon Is there anything stopping us from doing export * from './styles';?

@mui-pr-bot
Copy link

No bundle size changes comparing ed2ade1...a0bf1e5

Generated by 🚫 dangerJS against a0bf1e5

@eps1lon
Copy link
Member

eps1lon commented Jul 5, 2019

@eps1lon Is there anything stopping us from doing export * from './styles';?

Depends on the js index file. It should have the exact content, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@material-ui/core has no exported member 'MuiThemeProvider'
4 participants