Fix text field + value link line height. #1671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My internet keeps failing, sorry if this is like the 15th time I'm submitting this. Hope it works!
|
@quadrupleslap What is the issue? |
oliviertassinari
added
the
PR: needs revision
|
Hi @quadrupleslap could you let us know what issue this solves, and we can look at refining your PR and getting it merged? |
|
Since it's unclear what this PR solves, I'm closing for now. |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* Add jest debug configuration * Move jest config to separate file * Change input mask generation logic * Use new geFormatHelperText date-io method to generate helper text and placeholder * Update @date-io/jalaali and @date-io/hijiri * [docs] Update component demo titles * Fix mask input issues and update e2e tests * Optimize new masked input for date range picker * Remove meaningless comment * Update component based tests * Use auto injecting dependencies for hooks * Remove maskChar prop * Again remove `date` from the useEffect dependency in usePickerState * Make keyboard input isFocused mutable ref instead of state * Introduce renderInput API * Update DatePickers to include renderApi * Update TimePicker and DateTimePicker usages * Fix component tests * Migrate DateRangePicker into new API * Add className prop that attaching to the root of picker view * Properly pass TextField props in demos * Fix cypress url port * Fix labels * Fix cypress DatePicke.spec.ts * Fix issues with spreading props overrides * Fix bugs found by DateRange cypress tests * Fix TextField variant types * Fix port for CI docs next start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My internet keeps failing, sorry if this is like the 15th time I'm submitting this. Hope it works!