[EnhancedSwitch] added inputStyle prop to enhanced switch #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Can you add |
oliviertassinari
added
the
PR: needs revision
pbambusek
force-pushed
the
enhanced-switch
branch
from
f3ceae4
to
5cd2463
Compare
|
rebased & updated I'm not sure how you solve propTypes for docs when there is hierarchy of components, so I've added it to all switches. |
oliviertassinari
added
PR: Needs Review
and removed
PR: needs revision
oliviertassinari
added a commit
that referenced
this pull request
Feb 5, 2016
[EnhancedSwitch] added inputStyle prop to enhanced switch
|
@pbambusek Thanks! |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* Rename KeyboardIcon to CalendarIcon The icon components should be named after their content. * Rename `keyboardIcon` prop to `openPickerIcon` mui#1693 The prop should be named after the icon's functionality/usage. The new name matches the `hideOpenPickerButton` prop. The documentation on the prop already matches this wording. Tested by verifying that the two affected demo pages still work and show the customized icon. * Update lib/src/_shared/icons/CalendarIcon.tsx Co-Authored-By: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Dmitriy Kovalenko <dmtr.kovalenko@outlook.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
zannager
added
component: switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows overriding styles of backing input element. Having
position: absoluteby default doesn't always play nicely with surrounding elements.