Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Avoid mutating user's value prop #17085

Merged

Conversation

elmeerr
Copy link
Contributor

@elmeerr elmeerr commented Aug 21, 2019

Spread array before applying sort to avoid mutating user's value props

Closes #17082

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! labels Aug 21, 2019
@oliviertassinari oliviertassinari changed the title [Slider] bugfix: avoid mutating user props [Slider] Avoid mutating user's value prop Aug 21, 2019
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: aa4e2db...08c1dfe

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 329,374 329,387 89,969 89,971
@material-ui/core/Paper 0.00% 0.00% 68,774 68,774 20,490 20,490
@material-ui/core/Paper.esm 0.00% -0.01% 62,148 62,148 19,216 19,215
@material-ui/core/Popper 0.00% 0.00% 28,468 28,468 10,177 10,177
@material-ui/core/Textarea 0.00% 0.00% 5,094 5,094 2,137 2,137
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,614 1,614
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,386 16,386 5,829 5,829
@material-ui/core/useMediaQuery 0.00% 0.00% 2,541 2,541 1,058 1,058
@material-ui/lab +0.01% 🔺 0.00% 153,227 153,240 46,689 46,690
@material-ui/styles 0.00% +0.01% 🔺 51,492 51,492 15,305 15,307
@material-ui/system 0.00% +0.21% 🔺 15,658 15,658 4,361 4,370
Button 0.00% +0.02% 🔺 78,778 78,778 24,065 24,069
Modal 0.00% +0.02% 🔺 14,346 14,346 5,010 5,011
Portal 0.00% 0.00% 2,907 2,907 1,319 1,319
Rating 0.00% -0.00% 70,245 70,245 21,941 21,940
Slider +0.02% 🔺 +0.02% 🔺 74,470 74,483 23,058 23,063
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 53,510 53,510 13,855 13,855
docs.main 0.00% 0.00% 597,182 597,182 190,717 190,717
packages/material-ui/build/umd/material-ui.production.min.js 0.00% -0.00% 300,298 300,302 86,412 86,411

Generated by 🚫 dangerJS against 08c1dfe

@oliviertassinari oliviertassinari merged commit b560362 into mui:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Slider] Behavior/Implementation
4 participants