-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Popover] Fix update position action #17097
[Popover] Fix update position action #17097
Conversation
Details of bundle changes.Comparing: 343ae8e...365300c
|
@netochaves Could you add a failing test case? This should help to prevent similar regressions in the future. |
@oliviertassinari Sure! It will fail if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I have updated the test case to be failing without the fix. I think that we are good to go 🚢.
@netochaves Thanks! |
Fix #16901