[docs] Fix popover demo event.target is null #17104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
No bundle size changes comparing 343ae8e...44864d2 |
mbrookes
added
the
component: Popper
mbrookes
approved these changes
Aug 22, 2019
oliviertassinari
changed the title
behnammodi
reviewed
Aug 22, 2019
| @@ -99,9 +99,10 @@ function AnchorPlayground(props) { | |||
| }; | |||
|
|
|||
| const handleNumberInputChange = key => event => { | |||
| const value = event.target.value; | |||
There was a problem hiding this comment.
I think this is better:
const {value} = event.target;
There was a problem hiding this comment.
I don't think that it makes a difference. I believe that the convention in the codebase is to not destructure the two options are equivalent.
There was a problem hiding this comment.
How did this PR fix a bug? As far as I can see, there is no functional difference in the new code and old code; if target is null, it will still be dereferenced and cause a crash.
There was a problem hiding this comment.
Yeap, let's change the approach this time!
|
@spaceexperiment Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17101