[Backdrop] Render children inside div #17115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behnammodi
reviewed
Aug 22, 2019
| @@ -9,6 +9,9 @@ export const styles = { | |||
| root: { | |||
| zIndex: -1, | |||
| position: 'fixed', | |||
| display: 'flex', | |||
There was a problem hiding this comment.
Why not used Grid as a container?
There was a problem hiding this comment.
The idea is to come with a better default. I would expect more people to want to center the child.
There was a problem hiding this comment.
Do you agree with me?
There was a problem hiding this comment.
I think what @oliviertassinari meant was that a reasonable default would be to just have a center aligned child. In that case, I don't think Grid is necessary with this use case.
There was a problem hiding this comment.
Exactly, it's even better if the usage of the Grid is not required.
There was a problem hiding this comment.
@dominictwlee @oliviertassinari All right.
Details of bundle changes.Comparing: 343ae8e...1fad821
|
oliviertassinari
added
component: backdrop
oliviertassinari
approved these changes
Aug 22, 2019
|
@dominictwlee Thanks |
RohanM
added a commit
to conversation/ui
that referenced
this pull request
Nov 13, 2020
Fixes bug in Backdrop: mui/material-ui#17115 Changes: mui/material-ui@v4.3.2...v4.4.3
RohanM
added a commit
to conversation/ui
that referenced
this pull request
Nov 13, 2020
Fixes bug in Backdrop: mui/material-ui#17115 Changes: mui/material-ui@v4.3.2...v4.4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17084