Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve custom styles of the demos #17118

Merged
merged 20 commits into from
Aug 23, 2019
Merged

[docs] Improve custom styles of the demos #17118

merged 20 commits into from
Aug 23, 2019

Conversation

behnammodi
Copy link
Contributor

@behnammodi behnammodi commented Aug 22, 2019 •
edited
Loading

Change all string unit to theme.spacing
Change all multiple values to JSS rule

@behnammodi
Improved sample code
cab0d3f
@behnammodi
Improve BackToTop sample code
a2d1360
@behnammodi
Update style with jss structure
2062eaa
@behnammodi
Improve CustomizedBreadcrumbs sample code
2f25f88
@behnammodi
Improve ListDividers sample code
68018e1
@behnammodi
Updated with JSS rule in CustomizedExpansionPanels style
abc8bcd
@behnammodi
Updated with JSS rule in DetailedExpansionPanel style
0e4f0e1
@behnammodi
Use theme.spacing in InteractiveGrid style
4b0cbb4
@behnammodi
Updated CustomizedMenus with JSS rule
1d4668e
@behnammodi
Updated ServerModal sample code with JSS rule
cc53203
@behnammodi
Updated SimpleModal with JSS rule
839f8c3
@behnammodi
SpringModal update with JSS rule
8befa62
@behnammodi
TransitionsModal updated with JSS rule
6b10fdc
@behnammodi
CustomizedSelects update with JSS rule
d6ee575
@behnammodi
Use theme.spacing in CustomizedSlider style
ca62cb6
@behnammodi
Use theme.spacing and JSS rule in CustomizedSwitches
d9ffe80
@behnammodi
Use theme.spacing and JSS rule in CustomizedInputBase
f8efba3
@behnammodi
Use theme.spacing in FilledTextFields style
092b7bb
@behnammodi
Added theme interface in ScrollTop
9d7314c
@behnammodi behnammodi changed the title Improve docs smpale code [docs ]Improve docs smpale code Aug 22, 2019
@behnammodi behnammodi changed the title [docs ]Improve docs smpale code [docs] Improve docs smpale code Aug 22, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 22, 2019 •
edited
Loading

No bundle size changes comparing b737e35...f6303c2

Generated by 🚫 dangerJS against f6303c2

@oliviertassinari oliviertassinari mentioned this pull request Aug 23, 2019
Closed
1 task
@oliviertassinari oliviertassinari changed the title [docs] Improve docs smpale code [docs] Use theme.spacing where appropriate Aug 23, 2019
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Aug 23, 2019
@oliviertassinari oliviertassinari changed the title [docs] Use theme.spacing where appropriate [docs] Improve custom styles of the demos Aug 23, 2019
oliviertassinari
oliviertassinari approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spending time on this topic. I have reverted any syntax that depends on https://cssinjs.org/jss-plugin-expand/. We don't bundle this plugin. Also, as we are transitioning to styled-components, we will most likely write the style of the demos in template CSS string. I say most likely as I believe it's the most popular approach in the industry (an assomption to verify with data).

@oliviertassinari oliviertassinari merged commit 2f83044 into mui:master Aug 23, 2019
@oliviertassinari
Copy link
Member

@uxitten Thanks

@behnammodi
Copy link
Contributor Author

@oliviertassinari You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behnammodi @mui-pr-bot @oliviertassinari