[docs] Remove unecessary createStyles in TypeScript Tabs demo #17164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes files in Tabs demo that uses
createStyles
when the Hook APImakeStyles
is already used. When using TypeScript,makeStyles
alone is enough --createStyles
is used only if the HOC APIwithStyles
is used -- because there are some type incompatibilities with some styles e.g. flexboxes (flexDirection
,flexGrow
, etc.).Some parts of the demo I left them as they were -- because I think HOC is more appropriate in these cases instead of Hooks, e.g.
https://github.com/mui-org/material-ui/blob/44c335c3b3f8669b16901c5f777bb5ba9e9241c0/docs/src/pages/components/tabs/CustomizedTabs.tsx#L16-L49
This is because
withStyles
generatesclasses
prop directly -- and almost all Material UI components can consumeclasses
prop from its parent. As they are more like "reusable sub-components", inliningwithStyles
with the components is better in my opinion.