Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Missing degree/option symbol #17189

Merged
merged 1 commit into from
Aug 26, 2019
Merged

[docs] Missing degree/option symbol #17189

merged 1 commit into from
Aug 26, 2019

Conversation

skube
Copy link
Contributor

@skube skube commented Aug 26, 2019

@mui-pr-bot
Copy link

No bundle size changes comparing eaadcf2...597fa74

Generated by 🚫 dangerJS against 597fa74

@oliviertassinari oliviertassinari changed the title Missing degree/option symbol [docs] Missing degree/option symbol Aug 26, 2019
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Aug 26, 2019
@oliviertassinari oliviertassinari merged commit 7b6a14b into mui:master Aug 26, 2019
@oliviertassinari
Copy link
Member

@skube Thanks

@skube skube deleted the patch-1 branch August 26, 2019 22:53
@mbrookes
Copy link
Member

mbrookes commented Aug 27, 2019 •
edited
Loading

I arrived too late.

"N°" isn't a common convention in English. When a number is abbreviated at all, it is more often "No.", but in either case with a capital N.

It's a moot point, however, since when listing options in English, it's simply:

  • Option 1
  • Option 2

@oliviertassinari
Copy link
Member

This looks even better!

@skube
Copy link
Contributor Author

skube commented Aug 27, 2019

Fair enough — I was just following the convention that seemed to have already been established. I agree, "N°" looks weird to me.

@mbrookes
Copy link
Member

Cool, would you like to fix it up?

@skube skube restored the patch-1 branch August 27, 2019 12:35
@skube
Copy link
Contributor Author

skube commented Aug 27, 2019 •
edited
Loading

Oops I think I might have created a duplicate PR? (#17200)

I tried to restore previous branch and edit within. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skube @mui-pr-bot @oliviertassinari @mbrookes