Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Typography] noWrap requires display block #17206

Merged
merged 5 commits into from
Aug 28, 2019
Merged

[Typography] noWrap requires display block #17206

merged 5 commits into from
Aug 28, 2019

Conversation

rbrishabh
Copy link
Contributor

Fixes #17138

Hey @oliviertassinari

Let me know if this needs any changes!

Thanks =)

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 27, 2019 •
edited
Loading

No bundle size changes comparing 8ec0e6f...c708ba7

Generated by 🚫 dangerJS against c708ba7

@oliviertassinari
Copy link
Member

tip: yarn docs:api.

mbrookes
mbrookes previously requested changes Aug 28, 2019
View reviewed changes
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@oliviertassinari oliviertassinari changed the title Fix - noWrap property for - variant="inherit" [Typography] noWrap requires display block Aug 28, 2019
@oliviertassinari oliviertassinari added component: Typography The React component. docs Improvements or additions to the documentation labels Aug 28, 2019
@eps1lon eps1lon merged commit 01cbe97 into mui:master Aug 28, 2019
@eps1lon
Copy link
Member

eps1lon commented Aug 28, 2019

@rbrishabh Thank you for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: Typography The React component. docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Typography] noWrap property does not work with variant="inherit"
5 participants
@rbrishabh @mui-pr-bot @oliviertassinari @eps1lon @mbrookes