[ContextPure] Fix broken style property #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix component using the ContextPure mixin. Implement the new shouldComponentUpdate suggeseted by shaurya947. We now rerender correctly when the current theme and the next theme are both undefined
|
@chrismcv What do you think? |
shaurya947
added a commit
that referenced
this pull request
Sep 25, 2015
[ContextPure] Fix broken style property
|
This looks good to me. Thanks @oliviertassinari and @chrismcv. This should also hopefully take care of #1719 |
Closed
zannager
added
the
package: styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix component using the ContextPure mixin.
Implement the new shouldComponentUpdate suggeseted by @shaurya947.
We now rerender correctly when the current theme and the next theme are both undefined
Follow #1718.