Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Require less strict tsconfig #17214

Merged
merged 1 commit into from
Aug 29, 2019
Merged

[docs] Require less strict tsconfig #17214

merged 1 commit into from
Aug 29, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Aug 28, 2019

Closes #16255

@eps1lon eps1lon added docs Improvements or additions to the documentation typescript labels Aug 28, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing fd9da3e...b8f8e98

Generated by 🚫 dangerJS against b8f8e98

@eps1lon eps1lon requested a review from mbrookes August 28, 2019 14:00
oliviertassinari
oliviertassinari approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strict mode options are the same that are required for every types package
published in the @types/ namespace.

💯

@oliviertassinari oliviertassinari merged commit 6400ddc into mui:master Aug 29, 2019
@eps1lon eps1lon deleted the docs/less-strict-ts branch August 30, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mbrookes mbrookes Awaiting requested review from mbrookes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider compatibility with a less strict typescript
3 participants
@eps1lon @mui-pr-bot @oliviertassinari