-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextField] Update outlined label when prop changes #17217
Conversation
Details of bundle changes.Comparing: 45d2ce2...089df7d
|
Thanks for working on this issue. I just hope this won't get abused by changing labels instead of remounting the form. i18n is really the only valid use case for a changing label. |
Welcome, Let me know if this needs any changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Regarding the accessibility aspect of the feature, I think that there is an opportunity to build a tool to address it, it's likely not specific to Material-UI nor React.
@Shubhamchinda Thanks |
In which release will this be available? In 4.3.3 I still have the problem. Thanks |
@kamami Wait for the next release (v4.4.0). |
@oliviertassinari I updated to 4.4.0, but the labels of my TextFields in Tabcontainer still overlap the border of the TextFields. Do I need to change some parameters of the TextFields to fix this bug since the update? |
@kamami If this issue still persists with 4.4 please open a new issue and fill out the template. This would help a lot. |
Fixes #16833
Fixes #14530
@oliviertassinari