Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] Update outlined label when prop changes #17217

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

Shubhamchinda
Copy link
Contributor

@Shubhamchinda Shubhamchinda commented Aug 28, 2019

@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 45d2ce2...089df7d

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 329,697 329,699 90,071 90,073
@material-ui/core/Paper 0.00% 0.00% 68,774 68,774 20,486 20,486
@material-ui/core/Paper.esm 0.00% 0.00% 62,148 62,148 19,216 19,216
@material-ui/core/Popper 0.00% 0.00% 28,468 28,468 10,177 10,177
@material-ui/core/Textarea 0.00% 0.00% 5,094 5,094 2,137 2,137
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,613 1,613
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,386 16,386 5,827 5,827
@material-ui/core/useMediaQuery 0.00% 0.00% 2,541 2,541 1,058 1,058
@material-ui/lab 0.00% 0.00% 153,545 153,545 46,752 46,752
@material-ui/styles 0.00% 0.00% 51,492 51,492 15,304 15,304
@material-ui/system 0.00% 0.00% 15,658 15,658 4,366 4,366
Button 0.00% 0.00% 78,778 78,778 24,072 24,072
Modal 0.00% 0.00% 14,346 14,346 5,010 5,010
Portal 0.00% 0.00% 2,907 2,907 1,318 1,318
Rating 0.00% 0.00% 70,245 70,245 21,948 21,948
Slider 0.00% 0.00% 74,483 74,483 23,064 23,064
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 52,305 52,305 13,790 13,790
docs.main 0.00% 0.00% 597,545 597,545 190,886 190,886
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 300,602 300,604 86,485 86,486

Generated by 🚫 dangerJS against 089df7d

@eps1lon
Copy link
Member

eps1lon commented Aug 28, 2019

Thanks for working on this issue.

I just hope this won't get abused by changing labels instead of remounting the form. i18n is really the only valid use case for a changing label.

@eps1lon eps1lon added component: text field This is the name of the generic UI component, not the React module! new feature New feature or request labels Aug 28, 2019
@Shubhamchinda
Copy link
Contributor Author

Thanks for working on this issue.

Welcome, Let me know if this needs any changes :)

@oliviertassinari oliviertassinari changed the title [TextField] Added label in TextField [TextField] Update outlined label when prop changes Aug 28, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Regarding the accessibility aspect of the feature, I think that there is an opportunity to build a tool to address it, it's likely not specific to Material-UI nor React.

@oliviertassinari
Copy link
Member

@Shubhamchinda Thanks

@kamami
Copy link

kamami commented Aug 31, 2019

In which release will this be available? In 4.3.3 I still have the problem. Thanks

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 31, 2019

@kamami Wait for the next release (v4.4.0).

@kamami
Copy link

kamami commented Aug 31, 2019

@oliviertassinari I updated to 4.4.0, but the labels of my TextFields in Tabcontainer still overlap the border of the TextFields. Do I need to change some parameters of the TextFields to fix this bug since the update?

@eps1lon
Copy link
Member

eps1lon commented Sep 2, 2019

@kamami If this issue still persists with 4.4 please open a new issue and fill out the template. This would help a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
5 participants