Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LinearProgress] Make color adapt to theme type #17219

Merged
merged 4 commits into from
Aug 31, 2019
Merged

[LinearProgress] Make color adapt to theme type #17219

merged 4 commits into from
Aug 31, 2019

Conversation

ahtcx
Copy link
Contributor

@ahtcx ahtcx commented Aug 28, 2019

I found the linear progress bars don't look amazing with a dark theme because it uses the lighten helper function, so I've made it use either lighten or darken depending on the current theme.

Current Proposed changes
Light
Dark

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 28, 2019

Details of bundle changes.

Comparing: 45d2ce2...d2e24af

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.06% -0.01% 329,697 329,491 90,071 90,061
@material-ui/core/Paper 0.00% -0.00% 68,774 68,774 20,486 20,485
@material-ui/core/Paper.esm 0.00% -0.02% 62,148 62,148 19,216 19,212
@material-ui/core/Popper -0.01% +0.13% 🔺 28,468 28,466 10,177 10,190
@material-ui/core/Textarea 0.00% 0.00% 5,094 5,094 2,137 2,137
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,613 1,613
@material-ui/core/styles/createMuiTheme 0.00% +0.02% 🔺 16,386 16,386 5,827 5,828
@material-ui/core/useMediaQuery 0.00% 0.00% 2,541 2,541 1,058 1,058
@material-ui/lab -0.00% -0.01% 153,545 153,538 46,752 46,745
@material-ui/styles 0.00% 0.00% 51,492 51,492 15,304 15,304
@material-ui/system +0.06% 🔺 -0.18% 15,658 15,668 4,366 4,358
Button -0.00% +0.02% 🔺 78,778 78,777 24,072 24,076
Modal -0.01% +0.18% 🔺 14,346 14,344 5,010 5,019
Portal 0.00% 0.00% 2,907 2,907 1,318 1,318
Rating -0.00% -0.01% 70,245 70,243 21,948 21,945
Slider 0.00% -0.01% 74,483 74,483 23,064 23,062
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 52,305 52,305 13,790 13,790
docs.main 0.00% 0.00% 597,545 597,545 190,886 190,886
packages/material-ui/build/umd/material-ui.production.min.js -0.06% -0.03% 300,602 300,416 86,485 86,462

Generated by 🚫 dangerJS against d2e24af

@oliviertassinari oliviertassinari added the component: LinearProgress The React component. label Aug 29, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahtcx Great initiative! The dark mode colors were 🤢. I have tried to increase the visibility a bit. Let me know what you think of the changes!

@ahtcx
Copy link
Contributor Author

ahtcx commented Aug 29, 2019

@oliviertassinari I think that does help a bit, looks good to me 😀

@mbrookes
Copy link
Member

@oliviertassinari Should the Slider match?

@oliviertassinari
Copy link
Member

@mbrookes Ohhhh, yeah! Does it mean that we can use the opacity instead of a custom color 😍?

@oliviertassinari
Copy link
Member

@mbrookes I'm out of options regarding how we can simplify the color approach. I have done my best. Any suggestion is welcome, otherwise, it should be good enough.

@oliviertassinari
Copy link
Member

@ahtcx Thanks!

@oliviertassinari oliviertassinari added the component: progress This is the name of the generic UI component, not the React module! label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y component: LinearProgress The React component. component: progress This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants