-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LinearProgress] Make color adapt to theme type #17219
[LinearProgress] Make color adapt to theme type #17219
Conversation
Details of bundle changes.Comparing: 45d2ce2...d2e24af
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahtcx Great initiative! The dark mode colors were 🤢. I have tried to increase the visibility a bit. Let me know what you think of the changes!
@oliviertassinari I think that does help a bit, looks good to me 😀 |
@oliviertassinari Should the Slider match? |
@mbrookes Ohhhh, yeah! Does it mean that we can use the opacity instead of a custom color 😍? |
@mbrookes I'm out of options regarding how we can simplify the color approach. I have done my best. Any suggestion is welcome, otherwise, it should be good enough. |
@ahtcx Thanks! |
I found the linear progress bars don't look amazing with a dark theme because it uses the
lighten
helper function, so I've made it use eitherlighten
ordarken
depending on the current theme.