Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Add ref type to every component #17286

Merged
merged 1 commit into from
Sep 3, 2019
Merged

[core] Add ref type to every component #17286

merged 1 commit into from
Sep 3, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 2, 2019

Adds ref type to

  • ListItemAvatar
  • Tooltop
  • SpeedDial
  • SpeedDialAction
  • ToggleButtonGroup

Removing AcceptRef parameter in StandardProps refs are now forwarded in every component so we no longer need it. Gets rid of one conditional in an attempt to isolate #17275

@mui-pr-bot
Copy link

No bundle size changes comparing d81e0a7...cd9c06c

Generated by 🚫 dangerJS against cd9c06c

@eps1lon eps1lon merged commit fba5135 into mui:master Sep 3, 2019
@eps1lon eps1lon deleted the refactor/core/simpler-standardprops branch September 3, 2019 07:00
@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes and removed package: material-ui Specific to @mui/material package: lab Specific to @mui/lab labels Jan 9, 2021
@eps1lon eps1lon added package: material-ui Specific to @mui/material package: lab Specific to @mui/lab and removed core Infrastructure work going on behind the scenes labels Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: lab Specific to @mui/lab package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari