Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react 0.14.0 rc1 #1732

Closed
wants to merge 6 commits into from
Closed

Update react 0.14.0 rc1 #1732

wants to merge 6 commits into from

Conversation

Aaike
Copy link
Contributor

@Aaike Aaike commented Sep 26, 2015

No description provided.

@oliviertassinari
Copy link
Member

I'm wondering. Why did you change onTouchTap for onClick?

@Aaike
Copy link
Contributor Author

Aaike commented Sep 26, 2015

As far as i understand, React 0.14.0 now handles tap events correctly using the onClick so there is no need for a separate tap-event plugin.
I did the same as what was done here : https://github.com/juhaelee/material-ui-io

They also seem to mention it in the react-tap-event-plugin readme that the plugin is just a temporary fix.

@oliviertassinari
Copy link
Member

So I don't understand why https://github.com/zilverline/react-tap-event-plugin add a react v0.14 support instead of making it deprecated.

@oliviertassinari
Copy link
Member

@s0meone any clue on this?

@Aaike
Copy link
Contributor Author

Aaike commented Sep 26, 2015

yes i am unsure now how it should be :)

After reading the list of breaking changes
it looks like the Touch events are now included with the react lib at react/lib/TapEventPlugin.js
You don't need to include them anymore from a separate plugin.
and you don't need to initialize them manually.

But i guess you still need to use the onTouchTap instead of onClick ...

A bit further down on that page in the Notable bug fixes section it sais :
Click events are handled by React DOM more reliably in mobile browsers, particularly in Mobile Safari.

So i'm not sure at this point.
If anybody could shed some light on this it would be great.

Let me know if i need to revert back to onTouchTap ;)

@s0meone
Copy link

s0meone commented Sep 26, 2015

Touch events are enabled by default now, which means touchstart, touchend, touchmove, touchcancel events are now handled by React's event system, without initializeTouchEvents().

React 0.14 rc1 doesn't include the TapEventPlugin. React's repository does include my fix however (although not credited or documented). And onClicks are still 300ms behind.

So if you want to use onTouchTap, you'll need react-tap-event-plugin. Nothing has changed really :)

@Aaike
Copy link
Contributor Author

Aaike commented Sep 26, 2015

thx for clearing that up.
switched back to using onTouchTap and react-tap-event-plugin ;)

@Aaike
Copy link
Contributor Author

Aaike commented Sep 26, 2015

closing this as the only change remaining is this one :
Change to ReactDOM.findDOMNode() and use separated react addon libs

and this PR is not up to date with the 0.12.0 release.

@Aaike Aaike closed this Sep 26, 2015
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
Bumps [cypress](https://github.com/cypress-io/cypress) from 4.4.0 to 4.5.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Commits](cypress-io/cypress@v4.4.0...v4.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@zannager zannager added the package: system Specific to @mui/system label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants