Change to ReactDOM.findDOMNode() and use separated react addon libs #1733
Conversation
Update themes.jsx
Changed 'static' to 'statics'
Fixed typo in src/card-expandable.jsx
| @@ -61,9 +65,7 @@ | |||
| "mocha": "^2.2.5", | |||
| "phantomjs": "^1.9.17", | |||
| "react-hot-loader": "^1.2.8", | |||
| "react-router": "^0.13.3", | |||
| "react-stub-context": "^0.3.0", | |||
There was a problem hiding this comment.
travis complains: Error: Cannot find module 'react-stub-context'.
There was a problem hiding this comment.
yeh react-stub-context hasn't been updated yet to react 0.14.
@shaurya947 said to just leave it out if it isn't used by the files source files : #1704
There was a problem hiding this comment.
Does this means that we can't fix the build until react-stub-context support react v0.14?
I will close #1725 when the build pass since I believe this PR is more appropriate.
There was a problem hiding this comment.
@Aaike @oliviertassinari I suggested leaving it out because I thought that might fix the build error.
What can we do now to make the build successful?
There was a problem hiding this comment.
@shaurya947 I'm gonna try to fix react-stub-context.
|
I think that we can close this PR since #1751 was merged. |
Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.0.6 to 8.1.0. - [Release notes](https://github.com/babel/babel-loader/releases) - [Changelog](https://github.com/babel/babel-loader/blob/master/CHANGELOG.md) - [Commits](babel/babel-loader@v8.0.6...v8.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
No description provided.