Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ButtonGroup] Fix missing divider if background color is set #17648

Merged

Conversation

neon98
Copy link
Contributor

@neon98 neon98 commented Oct 1, 2019

fixes #17495

@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 05c533b...7919532

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.01% 🔺 0.00% 332,538 332,562 90,732 90,732
@material-ui/core/Paper 0.00% 0.00% 68,935 68,935 20,541 20,541
@material-ui/core/Paper.esm 0.00% 0.00% 62,372 62,372 19,275 19,275
@material-ui/core/Popper 0.00% 0.00% 28,405 28,405 10,172 10,172
@material-ui/core/Textarea 0.00% 0.00% 5,082 5,082 2,136 2,136
@material-ui/core/TrapFocus 0.00% 0.00% 3,766 3,766 1,596 1,596
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,348 16,348 5,818 5,818
@material-ui/core/useMediaQuery 0.00% 0.00% 2,488 2,488 1,050 1,050
@material-ui/lab 0.00% 0.00% 143,405 143,405 43,808 43,808
@material-ui/styles 0.00% 0.00% 51,694 51,694 15,364 15,364
@material-ui/system 0.00% 0.00% 15,581 15,581 4,341 4,341
Button 0.00% 0.00% 78,772 78,772 24,043 24,043
Modal 0.00% 0.00% 14,542 14,542 5,113 5,113
Portal 0.00% 0.00% 2,907 2,907 1,318 1,318
Rating 0.00% 0.00% 70,238 70,238 21,929 21,929
Slider 0.00% 0.00% 75,379 75,379 23,260 23,260
colorManipulator 0.00% 0.00% 3,835 3,835 1,519 1,519
docs.landing 0.00% 0.00% 54,267 54,267 14,344 14,344
docs.main 0.00% 0.00% 588,062 588,062 188,043 188,043
packages/material-ui/build/umd/material-ui.production.min.js +0.01% 🔺 -0.00% 303,356 303,380 87,276 87,275

Generated by 🚫 dangerJS against 7919532

@oliviertassinari oliviertassinari changed the title [ButtonGroup] fix missing divider between buttons if background color is set [ButtonGroup] Fix missing divider between buttons if background color is set Oct 1, 2019
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: ButtonGroup The React component. labels Oct 1, 2019
@oliviertassinari oliviertassinari changed the title [ButtonGroup] Fix missing divider between buttons if background color is set [ButtonGroup] Fix missing divider if background color is set Oct 1, 2019
@oliviertassinari oliviertassinari merged commit 7283e02 into mui:master Oct 1, 2019
@oliviertassinari
Copy link
Member

Thanks! We leave 1 week for people that claim an issue, it seems that the delay has just expired in your favor for this one :).

@neon98
Copy link
Contributor Author

neon98 commented Oct 1, 2019

haha! yes 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: ButtonGroup The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ButtonGroup] Missing divider between buttons if backgroundColor is set
3 participants