Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Batch small changes #17910

Merged
merged 16 commits into from
Oct 18, 2019

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 16, 2019

A 2 hours effort. I might have bundled too many unrelated topics 😔. After ~8 commits, it feels too much.

@oliviertassinari oliviertassinari added the umbrella For grouping multiple issues to provide a holistic view label Oct 16, 2019
@mui mui deleted a comment from codesandbox-ci bot Oct 16, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 16, 2019

No bundle size changes comparing 5d564f9...133e635

Generated by 🚫 dangerJS against 133e635

@codesandbox-ci

This comment has been minimized.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Though 2400 line diff is barely manageable in GitHubs UI.

docs/src/pages/components/tree-view/tree-view.md Outdated Show resolved Hide resolved
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 17, 2019

Looks good. Though 2400 line diff is barely manageable in GitHubs UI.

@eps1lon Agree! Thanks for the review, the API markdown diff is blowing it way.

Starting of with parentheses looks weird. I would just say that it implements the behavior described in the aria practices and include the link. We don't know if it is "complete" since that isn't defined and "no assistance required" might be misunderstood. You still need assistive technology to use it.

I'm eager to find a better approach to link the relevant accessibility resources. The parentheses are used in the other pages. I hope we can find a solution that also enables us to link

  1. The source, very important to increase people's trust when they see, for instance, a TextareaAutosize: where are the sources?!
  2. The material design specification. It's relatively random right now.
  3. The relevant accessibility resources.

I have started to benchmark a bit how we could solve this problem (for a potential future pull request)

Capture d’écran 2019-10-17 à 14 11 28
https://vuetifyjs.com/en/components/buttons#buttons

Capture d’écran 2019-10-17 à 14 14 44
https://orbit.kiwi/components/collapse/react/

In the following example, we demonstrate how to use [notistack](https://github.com/iamhosseindhv/notistack).
notistack makes it easy to display snackbars (so you don't have to deal with open/close state of them).
It also enables you to stack them on top of one another (although this is discouraged by the specification).
We demonstrate how to use [notistack](https://github.com/iamhosseindhv/notistack).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We demonstrate how to use [notistack](https://github.com/iamhosseindhv/notistack).
This example demonstrates how to use [notistack](https://github.com/iamhosseindhv/notistack).

notistack makes it easy to display snackbars (so you don't have to deal with open/close state of them).
It also enables you to stack them on top of one another (although this is discouraged by the specification).
We demonstrate how to use [notistack](https://github.com/iamhosseindhv/notistack).
notistack has an **imperative API** that makes it easy to display toasts (so you don't have to deal with open/close state of them).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
notistack has an **imperative API** that makes it easy to display toasts (so you don't have to deal with open/close state of them).
notistack has an **imperative API** that makes it easy to display snackbars, without having to handle their open/close state.

@mbrookes
Copy link
Member

Oops! Started this this morning and missed that it was since merged.

@oliviertassinari oliviertassinari deleted the batch-small-changes-v2 branch October 25, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs/API] Some components missing children prop
4 participants