-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Batch small changes #17910
[core] Batch small changes #17910
Conversation
No bundle size changes comparing 5d564f9...133e635 |
e738b99
to
e0ed6a5
Compare
This comment has been minimized.
This comment has been minimized.
e0ed6a5
to
0e2f51f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Though 2400 line diff is barely manageable in GitHubs UI.
@eps1lon Agree! Thanks for the review, the API markdown diff is blowing it way.
I'm eager to find a better approach to link the relevant accessibility resources. The parentheses are used in the other pages. I hope we can find a solution that also enables us to link
I have started to benchmark a bit how we could solve this problem (for a potential future pull request) |
In the following example, we demonstrate how to use [notistack](https://github.com/iamhosseindhv/notistack). | ||
notistack makes it easy to display snackbars (so you don't have to deal with open/close state of them). | ||
It also enables you to stack them on top of one another (although this is discouraged by the specification). | ||
We demonstrate how to use [notistack](https://github.com/iamhosseindhv/notistack). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We demonstrate how to use [notistack](https://github.com/iamhosseindhv/notistack). | |
This example demonstrates how to use [notistack](https://github.com/iamhosseindhv/notistack). |
notistack makes it easy to display snackbars (so you don't have to deal with open/close state of them). | ||
It also enables you to stack them on top of one another (although this is discouraged by the specification). | ||
We demonstrate how to use [notistack](https://github.com/iamhosseindhv/notistack). | ||
notistack has an **imperative API** that makes it easy to display toasts (so you don't have to deal with open/close state of them). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notistack has an **imperative API** that makes it easy to display toasts (so you don't have to deal with open/close state of them). | |
notistack has an **imperative API** that makes it easy to display snackbars, without having to handle their open/close state. |
Oops! Started this this morning and missed that it was since merged. |
A 2 hours effort. I might have bundled too many unrelated topics 😔. After ~8 commits, it feels too much.