Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add TS demo for MaterialTable #17938

Merged
merged 2 commits into from
Oct 20, 2019

Conversation

schapka
Copy link
Contributor

@schapka schapka commented Oct 19, 2019

Add TS demo for MaterialTable

Issue: #14897

@schapka schapka changed the title Add ts demo MaterialTableDemo.tsx Add TS demo for MaterialTable Oct 19, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 19, 2019

No bundle size changes comparing f8080a6...c118401

Generated by 🚫 dangerJS against c118401

@eps1lon eps1lon mentioned this pull request Oct 19, 2019
@oliviertassinari oliviertassinari changed the title Add TS demo for MaterialTable [docs] Add TS demo for MaterialTable Oct 19, 2019
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Oct 19, 2019
resolve();
const data = [...state.data];
data.splice(data.indexOf(oldData), 1);
setState({ ...state, data });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to change these to use the callback instead of reading the state object

@eps1lon eps1lon merged commit 930ab9a into mui:master Oct 20, 2019
@eps1lon
Copy link
Member

eps1lon commented Oct 20, 2019

@schapka Much appreciated, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants