Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Fix Gatsby broken example #18321

Merged
merged 4 commits into from
Nov 12, 2019
Merged

[examples] Fix Gatsby broken example #18321

merged 4 commits into from
Nov 12, 2019

Conversation

savi2w
Copy link

@savi2w savi2w commented Nov 11, 2019 •
edited
Loading

Fix proposed by Gatsby Documentation.

if main isn’t set, it is recommended to create an empty index.js file with the contents //no-op (short for no-operation)

Closes #18194.

@mui-pr-bot
Copy link

mui-pr-bot commented Nov 11, 2019 •
edited
Loading

No bundle size changes comparing 2df006e...b293a49

Generated by 🚫 dangerJS against b293a49

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Nov 12, 2019
@oliviertassinari oliviertassinari merged commit a26446f into mui:master Nov 12, 2019
@oliviertassinari
Copy link
Member

@weslenng It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@savi2w savi2w deleted the fix/Gatsby/example branch May 9, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Gatsby Example is broken
3 participants
@savi2w @mui-pr-bot @oliviertassinari